From 046d6ab01cc8892a7fd49a53e9dc94b2fd78acc9 Mon Sep 17 00:00:00 2001 From: "c.lamboo" Date: Wed, 8 Feb 2023 11:48:32 +0100 Subject: [PATCH 1/6] Re-enable support towers Decrease `support_offset` setting as using both support towers and support horizontal expansion would apply the same concept twice. Remove duplicate settings in other ultimaker profiles. Contributes to CURA-10220 Co-authored-by: Rijk van Manen --- resources/definitions/ultimaker.def.json | 4 ++-- .../quality/ultimaker3/um3_bb0.4_PVA_Draft_Print.inst.cfg | 1 - .../quality/ultimaker3/um3_bb0.4_PVA_Fast_Print.inst.cfg | 1 - .../quality/ultimaker3/um3_bb0.4_PVA_High_Quality.inst.cfg | 1 - .../quality/ultimaker3/um3_bb0.4_PVA_Normal_Quality.inst.cfg | 1 - .../quality/ultimaker3/um3_bb0.8_PVA_Draft_Print.inst.cfg | 1 - .../ultimaker3/um3_bb0.8_PVA_Superdraft_Print.inst.cfg | 1 - .../quality/ultimaker3/um3_bb0.8_PVA_Verydraft_Print.inst.cfg | 1 - 8 files changed, 2 insertions(+), 9 deletions(-) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index 4b91b61064..3712bb6771 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -119,8 +119,8 @@ "support_interface_pattern": { "value": "'zigzag'" }, "support_interface_skip_height": { "value": "layer_height" }, "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, - "support_offset": { "value": "3 if support_interface_enable else 0" }, - "support_use_towers": { "value": false }, + "support_offset": { "value": "support_line_width if support_interface_enable else 0" }, + "support_use_towers": { "value": true }, "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, "support_xy_distance": { "value": "1" }, "support_xy_distance_overhang": { "value": "0.2" }, diff --git a/resources/quality/ultimaker3/um3_bb0.4_PVA_Draft_Print.inst.cfg b/resources/quality/ultimaker3/um3_bb0.4_PVA_Draft_Print.inst.cfg index 9eac7f29f1..5a0e2d20cb 100644 --- a/resources/quality/ultimaker3/um3_bb0.4_PVA_Draft_Print.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.4_PVA_Draft_Print.inst.cfg @@ -21,5 +21,4 @@ skin_overlap = 20 skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.4_PVA_Fast_Print.inst.cfg b/resources/quality/ultimaker3/um3_bb0.4_PVA_Fast_Print.inst.cfg index 126d80c06f..78d3f70cfe 100644 --- a/resources/quality/ultimaker3/um3_bb0.4_PVA_Fast_Print.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.4_PVA_Fast_Print.inst.cfg @@ -22,5 +22,4 @@ skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_infill_sparse_thickness = =2*layer_height support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.4_PVA_High_Quality.inst.cfg b/resources/quality/ultimaker3/um3_bb0.4_PVA_High_Quality.inst.cfg index 66dc0ba220..1833790825 100644 --- a/resources/quality/ultimaker3/um3_bb0.4_PVA_High_Quality.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.4_PVA_High_Quality.inst.cfg @@ -20,5 +20,4 @@ skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_infill_sparse_thickness = =3*layer_height support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.4_PVA_Normal_Quality.inst.cfg b/resources/quality/ultimaker3/um3_bb0.4_PVA_Normal_Quality.inst.cfg index ce29e5ba13..11e18722dd 100644 --- a/resources/quality/ultimaker3/um3_bb0.4_PVA_Normal_Quality.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.4_PVA_Normal_Quality.inst.cfg @@ -20,5 +20,4 @@ skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_infill_sparse_thickness = =2*layer_height support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.8_PVA_Draft_Print.inst.cfg b/resources/quality/ultimaker3/um3_bb0.8_PVA_Draft_Print.inst.cfg index 91a9f57566..046f49887e 100644 --- a/resources/quality/ultimaker3/um3_bb0.8_PVA_Draft_Print.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.8_PVA_Draft_Print.inst.cfg @@ -19,5 +19,4 @@ retraction_count_max = 5 skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.8_PVA_Superdraft_Print.inst.cfg b/resources/quality/ultimaker3/um3_bb0.8_PVA_Superdraft_Print.inst.cfg index 4b877c253c..e6a616150e 100644 --- a/resources/quality/ultimaker3/um3_bb0.8_PVA_Superdraft_Print.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.8_PVA_Superdraft_Print.inst.cfg @@ -18,5 +18,4 @@ retraction_count_max = 5 skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_interface_enable = True -support_use_towers = True diff --git a/resources/quality/ultimaker3/um3_bb0.8_PVA_Verydraft_Print.inst.cfg b/resources/quality/ultimaker3/um3_bb0.8_PVA_Verydraft_Print.inst.cfg index e6fbd842c4..e5d469ae21 100644 --- a/resources/quality/ultimaker3/um3_bb0.8_PVA_Verydraft_Print.inst.cfg +++ b/resources/quality/ultimaker3/um3_bb0.8_PVA_Verydraft_Print.inst.cfg @@ -18,5 +18,4 @@ retraction_count_max = 5 skirt_brim_minimal_length = =min(2000, 175/(layer_height*line_width)) support_brim_enable = True support_interface_enable = True -support_use_towers = True From 46fe9c056817ee92130a4127a9d1d170cec07472 Mon Sep 17 00:00:00 2001 From: "c.lamboo" Date: Wed, 8 Feb 2023 14:15:31 +0100 Subject: [PATCH 2/6] Set support tower angle to 0 This enlarges small areas to immediately be equal to support_tower_diameter^2. Contributes to CURA-10220 Co-authored-by: Rijk van Manen --- resources/definitions/ultimaker.def.json | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index 3712bb6771..e25fef22c1 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -120,6 +120,7 @@ "support_interface_skip_height": { "value": "layer_height" }, "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, "support_offset": { "value": "support_line_width if support_interface_enable else 0" }, + "support_tower_roof_angle": { "value": "0" }, "support_use_towers": { "value": true }, "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, "support_xy_distance": { "value": "1" }, From 44b71dd8f1a0187f467303f1cf2dd68f515de614 Mon Sep 17 00:00:00 2001 From: "c.lamboo" Date: Wed, 8 Feb 2023 15:04:34 +0100 Subject: [PATCH 3/6] Update support horizontal expansion value Contributes to CURA-10220 Co-authored-by: Rijk van Manen --- resources/definitions/ultimaker.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index e25fef22c1..8324874ce7 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -119,7 +119,7 @@ "support_interface_pattern": { "value": "'zigzag'" }, "support_interface_skip_height": { "value": "layer_height" }, "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, - "support_offset": { "value": "support_line_width if support_interface_enable else 0" }, + "support_offset": { "value": "0.9 if support_interface_enable else 0" }, "support_tower_roof_angle": { "value": "0" }, "support_use_towers": { "value": true }, "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, From 06c0ccb5729561e91bb802c6b29531086a20298e Mon Sep 17 00:00:00 2001 From: "c.lamboo" Date: Wed, 8 Feb 2023 15:44:49 +0100 Subject: [PATCH 4/6] Only set support_tower_roof_angle to 0 if support_interface is enabled Contributes to CURA-10220 Co-authored-by: Rijk van Manen --- resources/definitions/ultimaker.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index 8324874ce7..760f3bafb2 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -120,7 +120,7 @@ "support_interface_skip_height": { "value": "layer_height" }, "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, "support_offset": { "value": "0.9 if support_interface_enable else 0" }, - "support_tower_roof_angle": { "value": "0" }, + "support_tower_roof_angle": { "value": "65 if support_interface_enable else 0" }, "support_use_towers": { "value": true }, "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, "support_xy_distance": { "value": "1" }, From b37d80a546e484a02216b657e550fe8f61424081 Mon Sep 17 00:00:00 2001 From: Casper Lamboo Date: Wed, 8 Feb 2023 16:14:24 +0100 Subject: [PATCH 5/6] Don't duplicate default setting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- resources/definitions/ultimaker.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index 760f3bafb2..e051ebb692 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -121,7 +121,7 @@ "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, "support_offset": { "value": "0.9 if support_interface_enable else 0" }, "support_tower_roof_angle": { "value": "65 if support_interface_enable else 0" }, - "support_use_towers": { "value": true }, + "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, "support_xy_distance": { "value": "1" }, "support_xy_distance_overhang": { "value": "0.2" }, From fba299280f66388dd6170c5896fb5f54f7b3bad2 Mon Sep 17 00:00:00 2001 From: casperlamboo Date: Wed, 8 Feb 2023 15:15:40 +0000 Subject: [PATCH 6/6] Applied printer-linter format --- resources/definitions/ultimaker.def.json | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index e051ebb692..cf257d0ea6 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -121,7 +121,6 @@ "support_line_distance": { "minimum_value_warning": "0 if support_structure == 'tree' else support_line_width" }, "support_offset": { "value": "0.9 if support_interface_enable else 0" }, "support_tower_roof_angle": { "value": "65 if support_interface_enable else 0" }, - "support_wall_count": { "value": "1 if support_structure == 'tree' else 0" }, "support_xy_distance": { "value": "1" }, "support_xy_distance_overhang": { "value": "0.2" },