From 5cfe71e516005bf08d7048ee21f8e53f9ff161d9 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Fri, 20 Mar 2020 14:52:33 +0100 Subject: [PATCH] Fix binding loop in action panel widget This widget can't set its width to the width of its children, since its children anchor to its right-hand side which depends on the width. This fixes the following warning in the log: 2020-03-20 14:25:20,351 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/plugins/PrepareStage/PrepareMain.qml:16:5: QML ActionPanelWidget: Binding loop detected for property width Done during Turbo Testing and Tooling. --- plugins/PrepareStage/PrepareMain.qml | 2 +- resources/qml/ActionPanel/ActionPanelWidget.qml | 3 +-- .../Recommended/RecommendedSupportSelector.qml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/PrepareStage/PrepareMain.qml b/plugins/PrepareStage/PrepareMain.qml index bfeb62f0e8..ab3cf0e07c 100644 --- a/plugins/PrepareStage/PrepareMain.qml +++ b/plugins/PrepareStage/PrepareMain.qml @@ -1,4 +1,4 @@ -//Copyright (c) 2019 Ultimaker B.V. +//Copyright (c) 2020 Ultimaker B.V. //Cura is released under the terms of the LGPLv3 or higher. import QtQuick 2.4 diff --git a/resources/qml/ActionPanel/ActionPanelWidget.qml b/resources/qml/ActionPanel/ActionPanelWidget.qml index 6efa77518b..4d9a5eeb69 100644 --- a/resources/qml/ActionPanel/ActionPanelWidget.qml +++ b/resources/qml/ActionPanel/ActionPanelWidget.qml @@ -1,4 +1,4 @@ -// Copyright (c) 2019 Ultimaker B.V. +// Copyright (c) 2020 Ultimaker B.V. // Cura is released under the terms of the LGPLv3 or higher. import QtQuick 2.7 @@ -15,7 +15,6 @@ import Cura 1.0 as Cura Item { id: base - width: childrenRect.width height: childrenRect.height visible: CuraApplication.platformActivity diff --git a/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml b/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml index 8caf4a73e6..f227dddaf9 100644 --- a/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml +++ b/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml @@ -1,4 +1,4 @@ -// Copyright (c) 2018 Ultimaker B.V. +// Copyright (c) 2020 Ultimaker B.V. // Cura is released under the terms of the LGPLv3 or higher. import QtQuick 2.10