3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
CURA-7959

Co-authored-by: Ghostkeeper <Ghostkeeper@users.noreply.github.com>
This commit is contained in:
Jaime van Kessel 2021-05-05 09:32:59 +02:00 • committed by GitHub
parent 6dd62f9024
commit 5700e44914
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/DigitalLibrary/tests/TestDFFileExportAndUploadManager.py
View file

@ -17,7 +17,7 @@ def upload_manager():
}]) }])
node = MagicMock(name = "SceneNode") node = MagicMock(name = "SceneNode")
application = MagicMock(name = "CuraApplication") application = MagicMock(name = "CuraApplication")
with patch("cura.CuraApplication.CuraApplication.getInstance", MagicMock(return_value=application)): with patch("cura.CuraApplication.CuraApplication.getInstance", MagicMock(return_value = application)):
return DFFileExportAndUploadManager(file_handlers = {"3mf": file_handler}, return DFFileExportAndUploadManager(file_handlers = {"3mf": file_handler},
nodes = [node], nodes = [node],
library_project_id = "test_library_project_id", library_project_id = "test_library_project_id",
@ -41,7 +41,7 @@ def test_extractErrorTitle(upload_manager, input, expected_result):
def test_exportJobError(upload_manager): def test_exportJobError(upload_manager):
mocked_application = MagicMock() mocked_application = MagicMock()
with patch("UM.Application.Application.getInstance", MagicMock(return_value=mocked_application)): with patch("UM.Application.Application.getInstance", MagicMock(return_value = mocked_application)):
upload_manager._onJobExportError("file_name.3mf") upload_manager._onJobExportError("file_name.3mf")
# Ensure that message was displayed # Ensure that message was displayed

2
plugins/DigitalLibrary/tests/TestDigitalFactoryFileModel.py
View file

@ -4,7 +4,7 @@ from src.DigitalFactoryFileModel import DigitalFactoryFileModel
from src.DigitalFactoryFileResponse import DigitalFactoryFileResponse from src.DigitalFactoryFileResponse import DigitalFactoryFileResponse
file_1 = DigitalFactoryFileResponse(client_id ="client_id_1", file_1 = DigitalFactoryFileResponse(client_id = "client_id_1",
content_type = "zomg", content_type = "zomg",
file_name = "file_1.3mf", file_name = "file_1.3mf",
file_id = "file_id_1", file_id = "file_id_1",

9
plugins/DigitalLibrary/tests/TestDigitalLibraryApiClient.py
View file

@ -45,16 +45,16 @@ def test_getProjectsFirstPage(api_client):
args = http_manager.get.call_args_list[0] args = http_manager.get.call_args_list[0]
# Ensure that it's called with the right limit # Ensure that it's called with the right limit
assert args[0][0] == 'https://api.ultimaker.com/cura/v1/projects?limit=20' assert args[0][0] == "https://api.ultimaker.com/cura/v1/projects?limit=20"
# Change the limit & try again # Change the limit & try again
http_manager.get.reset_mock() http_manager.get.reset_mock()
pagination_manager.limit = 80 pagination_manager.limit = 80
api_client.getProjectsFirstPage(on_finished=finished_callback, failed=failed_callback) api_client.getProjectsFirstPage(on_finished = finished_callback, failed = failed_callback)
args = http_manager.get.call_args_list[0] args = http_manager.get.call_args_list[0]
# Ensure that it's called with the right limit # Ensure that it's called with the right limit
assert args[0][0] == 'https://api.ultimaker.com/cura/v1/projects?limit=80' assert args[0][0] == "https://api.ultimaker.com/cura/v1/projects?limit=80"
def test_getMoreProjects_noNewProjects(api_client): def test_getMoreProjects_noNewProjects(api_client):
@ -70,7 +70,7 @@ def test_getMoreProjects_noNewProjects(api_client):
def test_getMoreProjects_hasNewProjects(api_client): def test_getMoreProjects_hasNewProjects(api_client):
api_client.hasMoreProjectsToLoad = MagicMock(return_value=True) api_client.hasMoreProjectsToLoad = MagicMock(return_value = True)
http_manager = MagicMock() http_manager = MagicMock()
api_client._http = http_manager api_client._http = http_manager
@ -84,4 +84,3 @@ def test_getMoreProjects_hasNewProjects(api_client):
def test_clear(api_client): def test_clear(api_client):
api_client.clear() api_client.clear()
api_client._projects_pagination_mgr.reset.assert_called_once() api_client._projects_pagination_mgr.reset.assert_called_once()