Apply suggestions from code review

CURA-7959

Co-authored-by: Ghostkeeper <Ghostkeeper@users.noreply.github.com>
This commit is contained in:
Jaime van Kessel 2021-05-05 09:32:59 +02:00 committed by GitHub
parent 6dd62f9024
commit 5700e44914
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 9 deletions

View file

@ -17,7 +17,7 @@ def upload_manager():
}])
node = MagicMock(name = "SceneNode")
application = MagicMock(name = "CuraApplication")
with patch("cura.CuraApplication.CuraApplication.getInstance", MagicMock(return_value=application)):
with patch("cura.CuraApplication.CuraApplication.getInstance", MagicMock(return_value = application)):
return DFFileExportAndUploadManager(file_handlers = {"3mf": file_handler},
nodes = [node],
library_project_id = "test_library_project_id",
@ -41,8 +41,8 @@ def test_extractErrorTitle(upload_manager, input, expected_result):
def test_exportJobError(upload_manager):
mocked_application = MagicMock()
with patch("UM.Application.Application.getInstance", MagicMock(return_value=mocked_application)):
with patch("UM.Application.Application.getInstance", MagicMock(return_value = mocked_application)):
upload_manager._onJobExportError("file_name.3mf")
# Ensure that message was displayed
mocked_application.showMessageSignal.emit.assert_called_once()
mocked_application.showMessageSignal.emit.assert_called_once()