3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix losing global quality changes when reading a 3MF with a CFFF

Browse source 
By using "pass" when the IndexError occured while reading the quality changes, empty quality
changes containers were added to the registry. These empty quality changes were then used as
"global" quality_changes, since the container registry was simply picking the first quality
changes instance container that had an empty extruder stack. Therefore, the correct global
quality changes (that actually had the global settings that were changed, like the support)
was just ignored in the whole process.

CURA-7549
This commit is contained in:
Kostas Karmas 2020-07-07 10:43:02 +02:00
parent c7bbc139f7
commit 4f97089e47
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/3MFReader/ThreeMFWorkspaceReader.py
View file

@ -471,7 +471,7 @@ class ThreeMFWorkspaceReader(WorkspaceReader):
extruder_info.intent_info = instance_container_info_dict[intent_id]
if not machine_conflict and containers_found_dict["machine"]:
if int(position) >= len(global_stack.extrurderList):
if int(position) >= len(global_stack.extruderList):
continue
existing_extruder_stack = global_stack.extruderList[int(position)]
@ -822,7 +822,7 @@ class ThreeMFWorkspaceReader(WorkspaceReader):
try:
extruder_stack = global_stack.extruderList[int(position)]
except IndexError:
pass
continue
intent_category = quality_changes_intent_category_per_extruder[position]
container = self._createNewQualityChanges(quality_changes_quality_type, intent_category, quality_changes_name, global_stack, extruder_stack)
container_info.container = container
@ -887,7 +887,7 @@ class ThreeMFWorkspaceReader(WorkspaceReader):
try:
extruder_stack = global_stack.extruderList[int(position)]
except IndexError:
extruder_stack = None
continue
intent_category = quality_changes_intent_category_per_extruder[position]
container = self._createNewQualityChanges(quality_changes_quality_type, intent_category, quality_changes_name, global_stack, extruder_stack)
container_info.container = container