3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 23:17:32 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Catch runtime errors when trying to disconnect signal

Browse source 
Contribute to CURA-8587
This commit is contained in:
Jelle Spijker 2021-12-16 17:07:42 +01:00
parent 0a7aee5c09
commit 4d8592c6b7
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/Marketplace/PackageList.py
View file

@ -55,8 +55,11 @@ class PackageList(ListModel):
def __del__(self) -> None: def __del__(self) -> None:
""" When this object is deleted it will loop through all registered API requests and aborts them """ """ When this object is deleted it will loop through all registered API requests and aborts them """
self.cleanUpAPIRequest() self.cleanUpAPIRequest()
try:
self.isLoadingChanged.disconnect() self.isLoadingChanged.disconnect()
self.hasMoreChanged.disconnect() self.hasMoreChanged.disconnect()
except RuntimeError:
pass
def abortRequest(self, request_id: str) -> None: def abortRequest(self, request_id: str) -> None:
"""Aborts a single request""" """Aborts a single request"""

3
plugins/Marketplace/PackageModel.py
View file

@ -88,7 +88,10 @@ class PackageModel(QObject):
self.setCanUpdate(self._package_id in self._package_manager.packagesWithUpdate) self.setCanUpdate(self._package_id in self._package_manager.packagesWithUpdate)
def __del__(self): def __del__(self):
try:
self._package_manager.packagesWithUpdateChanged.disconnect(self._processUpdatedPackages) self._package_manager.packagesWithUpdateChanged.disconnect(self._processUpdatedPackages)
except RuntimeError:
pass
def __eq__(self, other: object) -> bool: def __eq__(self, other: object) -> bool:
if isinstance(other, PackageModel): if isinstance(other, PackageModel):