3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-10 15:25:09 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Revert "Show warning when restoring backup failed"

Browse source 
We decided to add the warning message in a separate ticket for 4.11.

This reverts commit 584a387deb.
This commit is contained in:
Konstantinos Karmas 2021-06-25 09:22:12 +02:00
parent 9a27a63b7e
commit 4435a10f9d
1 changed files with 5 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

17
cura/Backups/Backup.py
View file

@ -7,7 +7,7 @@ import re
import shutil
from copy import deepcopy
from zipfile import ZipFile, ZIP_DEFLATED, BadZipfile
from typing import Dict, Optional, TYPE_CHECKING, List, Tuple
from typing import Dict, Optional, TYPE_CHECKING, List
from UM import i18nCatalog
from UM.Logger import Logger
@ -156,10 +156,7 @@ class Backup:
Logger.log("d", f"The following error occurred while trying to restore a Cura backup: {str(e)}")
self._showMessage(self.catalog.i18nc("@info:backup_failed", "The following error occurred while trying to restore a Cura backup:") + str(e))
return False
extracted, failed_files = self._extractArchive(archive, version_data_dir)
self._showMessage(
self.catalog.i18nc("@info:backup_failed",
"The following error occurred while trying to restore a Cura backup:" + "\n{}".format("\n".join(failed_files))))
extracted = self._extractArchive(archive, version_data_dir)
# Under Linux, preferences are stored elsewhere, so we copy the file to there.
if Platform.isLinux():
@ -178,7 +175,7 @@ class Backup:
return extracted
@staticmethod
def _extractArchive(archive: "ZipFile", target_path: str) -> Tuple[bool, List[str]]:
def _extractArchive(archive: "ZipFile", target_path: str) -> bool:
"""Extract the whole archive to the given target path.
:param archive: The archive as ZipFile.
@ -191,23 +188,19 @@ class Backup:
config_filename = CuraApplication.getInstance().getApplicationName() + ".cfg" # Should be there if valid.
if config_filename not in [file.filename for file in archive.filelist]:
Logger.logException("e", "Unable to extract the backup due to corruption of compressed file(s).")
return False, []
return False
Logger.log("d", "Removing current data in location: %s", target_path)
Resources.factoryReset()
Logger.log("d", "Extracting backup to location: %s", target_path)
name_list = archive.namelist()
failed_files = []
full_restore = True
for archive_filename in name_list:
try:
archive.extract(archive_filename, target_path)
except (PermissionError, EnvironmentError):
Logger.logException("e", f"Unable to extract the file {archive_filename} from the backup due to permission or file system errors.")
failed_files.append(archive_filename)
full_restore = False
CuraApplication.getInstance().processEvents()
return full_restore, failed_files
return True
def _obfuscate(self) -> Dict[str, str]:
"""