From 43b81c70db34b6f7ded09b46646c915d5ae40495 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Fri, 8 Feb 2019 10:32:54 +0100 Subject: [PATCH] Ensure that color for support extruder selector gets updated in all cases CURA-6144 --- .../Recommended/RecommendedSupportSelector.qml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml b/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml index b2a0ff972c..80174c2ce3 100644 --- a/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml +++ b/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml @@ -123,15 +123,15 @@ Item currentIndex: supportExtruderNr.properties.value property string color: "#fff" - - Binding + Connections { - // We override the color property's value when the ExtruderModel changes. So we need to use an - // explicit binding here otherwise we do not handle value changes after the model changes. - target: supportExtruderCombobox - property: "color" - value: supportExtruderCombobox.currentText != "" ? supportExtruderCombobox.model.getItem(supportExtruderCombobox.currentIndex).color : "" + target: extruderModel + onModelChanged: + { + supportExtruderCombobox.color = supportExtruderCombobox.model.getItem(supportExtruderCombobox.currentIndex).color + } } + onCurrentIndexChanged: supportExtruderCombobox.color = supportExtruderCombobox.model.getItem(supportExtruderCombobox.currentIndex).color Binding { @@ -302,6 +302,7 @@ Item property var extruderModel: CuraApplication.getExtrudersModel() + UM.SettingPropertyProvider { id: supportEnabled