3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-12 09:17:50 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add more TODO comments to clarify

Browse source
This commit is contained in:
ChrisTerBeke 2018-12-06 16:59:09 +01:00
parent ec03b012a7
commit 3ebefa4f8a
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugins/UM3NetworkPrinting/src/Cloud/CloudOutputDevice.py
View file

@ -287,6 +287,8 @@ class CloudOutputDevice(NetworkedPrinterOutputDevice):
# TODO: we see that not all data in the UI is correctly updated when the queue and active jobs change. # TODO: we see that not all data in the UI is correctly updated when the queue and active jobs change.
# TODO: we need to fix this here somehow by updating the correct output models. # TODO: we need to fix this here somehow by updating the correct output models.
# TODO: also the configuration drop down in the slice window is not populated because we are missing some data.
# TODO: to fix this we need to implement more data as shown in ClusterUM3OutputDevice._createPrintJobModel
for removed_job in removed_jobs: for removed_job in removed_jobs:
self._print_jobs.remove(removed_job) self._print_jobs.remove(removed_job)

1
plugins/UM3NetworkPrinting/src/Cloud/Models/CloudClusterPrintJob.py
View file

@ -40,7 +40,6 @@ class CloudClusterPrintJob(BaseModel):
# \param printer: The output model of the printer # \param printer: The output model of the printer
def createOutputModel(self, controller: CloudOutputController) -> UM3PrintJobOutputModel: def createOutputModel(self, controller: CloudOutputController) -> UM3PrintJobOutputModel:
model = UM3PrintJobOutputModel(controller, self.uuid, self.name) model = UM3PrintJobOutputModel(controller, self.uuid, self.name)
# TODO: implement more data as shown in ClusterUM3OutputDevice._createPrintJobModel
return model return model
## Updates an UM3 print job output model based on this cloud cluster print job. ## Updates an UM3 print job output model based on this cloud cluster print job.