From 3e6d4b92304f878f8ede375499b02e55fc0ad60b Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Mon, 8 May 2017 11:54:39 +0200 Subject: [PATCH] document why no signals connecting in project file pre-read CURA-3756 --- plugins/3MFReader/ThreeMFWorkspaceReader.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/3MFReader/ThreeMFWorkspaceReader.py b/plugins/3MFReader/ThreeMFWorkspaceReader.py index daa49e5f95..ebb6e8ef17 100644 --- a/plugins/3MFReader/ThreeMFWorkspaceReader.py +++ b/plugins/3MFReader/ThreeMFWorkspaceReader.py @@ -69,6 +69,11 @@ class ThreeMFWorkspaceReader(WorkspaceReader): container_id = self._stripFileToId(file_name) stack = ContainerStack(container_id) # Deserialize stack by converting read data from bytes to string + # + # NOTE: We do not connect the signals here is because all deserialized stacks here are NOT registered + # in the ContainerRegistry. So, some stacks from the profile won't be found in the ContainerRegistry, + # and thus failing the signal connecting. + # stack.deserialize(archive.open(file_name).read().decode("utf-8"), connect_signals=False) stack_type = stack.getMetaDataEntry("type")