3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 14:37:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

code review fixed for PAP

Browse source 
CURA-11403
This commit is contained in:
Saumya Jain 2024-03-05 14:08:39 +01:00
parent 3312ab66ba
commit 3e23ce1c37
4 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/3MFReader/WorkspaceDialog.py
View file

@ -184,11 +184,11 @@ class WorkspaceDialog(QObject):
return self._current_machine_name
@staticmethod
def getIndexOfCurrentMachine(list_of_dicts, key, value):
def getIndexOfCurrentMachine(list_of_dicts, key, value, defaultIndex):
for i, d in enumerate(list_of_dicts):
if d.get(key) == value: # found the dictionary
return i;
return 0
return i
return defaultIndex
@pyqtProperty(int, notify = machineNameChanged)
def currentMachinePositionIndex(self):
@ -197,7 +197,7 @@ class WorkspaceDialog(QObject):
@pyqtProperty(QObject, notify = updatableMachinesChanged)
def updatableMachinesModel(self) -> MachineListModel:
if self._current_machine_name != "":
self._current_machine_pos_index = self.getIndexOfCurrentMachine(self._updatable_machines_model.getItems(), "id", self._current_machine_name)
self._current_machine_pos_index = self.getIndexOfCurrentMachine(self._updatable_machines_model.getItems(), "id", self._current_machine_name, defaultIndex = 0)
else:
self._current_machine_pos_index = 0
return cast(MachineListModel, self._updatable_machines_model)