mirror of
https://github.com/Ultimaker/Cura.git
synced 2025-08-06 21:44:01 -06:00
Fix review comments.
- Text was cutoff instead of wrapped in Save Custom Profile (Rename Dialog). - Make the placeholder into a proper placeholder text. - Fix spelling (save -> safe). - Link didn't work as a link. - Slightly better tooltips. part of CURA-9347
This commit is contained in:
parent
6f651b922a
commit
3bc955fe8f
4 changed files with 30 additions and 22 deletions
|
@ -155,14 +155,6 @@ UM.Dialog
|
|||
discardButton.enabled = true;
|
||||
}
|
||||
}
|
||||
},
|
||||
Rectangle
|
||||
{
|
||||
// Workaround: If this placeholder isn't in here, then on repeated state-changes of the window, the rightButtons will be in the center (despite initially showing up right).
|
||||
visible: alternateStates.state != ""
|
||||
color: base.backgroundColor
|
||||
implicitHeight: UM.Theme.getSize("combobox").height
|
||||
implicitWidth: UM.Theme.getSize("combobox").width
|
||||
}
|
||||
]
|
||||
|
||||
|
|
|
@ -15,6 +15,7 @@ UM.Dialog
|
|||
buttonSpacing: UM.Theme.getSize("default_margin").width
|
||||
|
||||
property string object: ""
|
||||
property string objectPlaceholder: ""
|
||||
|
||||
property alias newName: nameField.text
|
||||
property bool validName: true
|
||||
|
@ -58,6 +59,8 @@ UM.Dialog
|
|||
id: nameField
|
||||
width: parent.width
|
||||
text: base.object
|
||||
placeholderText: base.objectPlaceholder
|
||||
placeholderTextColor: UM.Theme.getColor("text_field_text_disabled")
|
||||
maximumLength: 40
|
||||
selectByMouse: true
|
||||
onTextChanged: base.textChanged(text)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue