3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-16 11:17:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Apply suggestions from code review

Browse source 
Applied code review comments

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
This commit is contained in:
Jelle Spijker 2021-11-03 17:58:16 +01:00 • committed by GitHub
parent e7aecb6c06
commit 3a94fc0ced
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
plugins/Marketplace/LocalPackageList.py
View file

@ -18,7 +18,6 @@ catalog = i18nCatalog("cura")
class LocalPackageList(PackageList): class LocalPackageList(PackageList):
PackageRole = Qt.UserRole + 1
PACKAGE_SECTION_HEADER = { PACKAGE_SECTION_HEADER = {
"installed": "installed":
{ {
@ -46,7 +45,7 @@ class LocalPackageList(PackageList):
self.setErrorMessage("") # Clear any previous errors. self.setErrorMessage("") # Clear any previous errors.
self.setIsLoading(True) self.setIsLoading(True)
self._getLocalPackages() self._getLocalPackages()
self.setIsLoading(True) self.setIsLoading(False)
def _getLocalPackages(self) -> None: def _getLocalPackages(self) -> None:
""" Obtain the local packages. """ Obtain the local packages.

2
plugins/Marketplace/PackageList.py
View file

@ -42,7 +42,7 @@ class PackageList(ListModel):
""" Resets and clears the list""" """ Resets and clears the list"""
self.clear() self.clear()
isLoadingChanged = pyqtSignal() # The signal for isLoading property isLoadingChanged = pyqtSignal()
def setIsLoading(self, value: bool) -> None: def setIsLoading(self, value: bool) -> None:
if self._is_loading != value: if self._is_loading != value:

2
plugins/Marketplace/resources/qml/Marketplace.qml
View file

@ -66,7 +66,7 @@ Window
font: UM.Theme.getFont("large") font: UM.Theme.getFont("large")
color: UM.Theme.getColor("text") color: UM.Theme.getColor("text")
text: "" text: content.item ? content.item.pageTitle: catalog.i18nc("@title", "Loading...")
} }
} }

3
plugins/Marketplace/resources/qml/Packages.qml
View file

@ -25,11 +25,10 @@ ScrollView
spacing: UM.Theme.getSize("default_margin").height spacing: UM.Theme.getSize("default_margin").height
section.property: "package.sectionTitle" section.property: "package.sectionTitle"
section.criteria: ViewSection.FullString
section.delegate: Rectangle section.delegate: Rectangle
{ {
width: packagesListview.width width: packagesListview.width
height: sectionHeaderText.implicitHeight + UM.Theme.getSize("default_margin").height height: sectionHeaderText.height + UM.Theme.getSize("default_margin").height
color: UM.Theme.getColor("detail_background") color: UM.Theme.getColor("detail_background")