3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-10 07:15:03 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
Applied code review comments

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
This commit is contained in:
Jelle Spijker 2021-11-03 17:58:16 +01:00 • committed by GitHub
parent e7aecb6c06
commit 3a94fc0ced
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugins/Marketplace/resources/qml/Marketplace.qml
View file

@ -66,7 +66,7 @@ Window
font: UM.Theme.getFont("large")
color: UM.Theme.getColor("text")
text: ""
text: content.item ? content.item.pageTitle: catalog.i18nc("@title", "Loading...")
}
}

3
plugins/Marketplace/resources/qml/Packages.qml
View file

@ -25,11 +25,10 @@ ScrollView
spacing: UM.Theme.getSize("default_margin").height
section.property: "package.sectionTitle"
section.criteria: ViewSection.FullString
section.delegate: Rectangle
{
width: packagesListview.width
height: sectionHeaderText.implicitHeight + UM.Theme.getSize("default_margin").height
height: sectionHeaderText.height + UM.Theme.getSize("default_margin").height
color: UM.Theme.getColor("detail_background")