mirror of
https://github.com/Ultimaker/Cura.git
synced 2025-07-07 23:17:32 -06:00
Added missing tests for peripheral
Not part of the ticket, but I'm boyscouting this.
This commit is contained in:
parent
73c6676673
commit
34c3a04744
2 changed files with 23 additions and 1 deletions
|
@ -304,7 +304,7 @@ class PrinterOutputModel(QObject):
|
||||||
|
|
||||||
@pyqtProperty(str, notify = peripheralsChanged)
|
@pyqtProperty(str, notify = peripheralsChanged)
|
||||||
def peripherals(self) -> str:
|
def peripherals(self) -> str:
|
||||||
return ", ".join(*[peripheral.name for peripheral in self._peripherals])
|
return ", ".join([peripheral.name for peripheral in self._peripherals])
|
||||||
|
|
||||||
def addPeripheral(self, peripheral: Peripheral) -> None:
|
def addPeripheral(self, peripheral: Peripheral) -> None:
|
||||||
self._peripherals.append(peripheral)
|
self._peripherals.append(peripheral)
|
||||||
|
|
|
@ -6,6 +6,7 @@ import pytest
|
||||||
|
|
||||||
from cura.PrinterOutput.Models.PrintJobOutputModel import PrintJobOutputModel
|
from cura.PrinterOutput.Models.PrintJobOutputModel import PrintJobOutputModel
|
||||||
from cura.PrinterOutput.Models.PrinterOutputModel import PrinterOutputModel
|
from cura.PrinterOutput.Models.PrinterOutputModel import PrinterOutputModel
|
||||||
|
from cura.PrinterOutput.Peripheral import Peripheral
|
||||||
|
|
||||||
test_validate_data_get_set = [
|
test_validate_data_get_set = [
|
||||||
{"attribute": "name", "value": "YAY"},
|
{"attribute": "name", "value": "YAY"},
|
||||||
|
@ -81,3 +82,24 @@ def test_getAndUpdate(data):
|
||||||
getattr(model, "update" + attribute)(data["value"])
|
getattr(model, "update" + attribute)(data["value"])
|
||||||
# The signal should not fire again
|
# The signal should not fire again
|
||||||
assert signal.emit.call_count == 1
|
assert signal.emit.call_count == 1
|
||||||
|
|
||||||
|
|
||||||
|
def test_peripherals():
|
||||||
|
model = PrinterOutputModel(MagicMock())
|
||||||
|
model.peripheralsChanged = MagicMock()
|
||||||
|
|
||||||
|
peripheral = MagicMock(spec=Peripheral)
|
||||||
|
peripheral.name = "test"
|
||||||
|
peripheral2 = MagicMock(spec=Peripheral)
|
||||||
|
peripheral2.name = "test2"
|
||||||
|
|
||||||
|
model.addPeripheral(peripheral)
|
||||||
|
assert model.peripheralsChanged.emit.call_count == 1
|
||||||
|
model.addPeripheral(peripheral2)
|
||||||
|
assert model.peripheralsChanged.emit.call_count == 2
|
||||||
|
|
||||||
|
assert model.peripherals == "test, test2"
|
||||||
|
|
||||||
|
model.removePeripheral(peripheral)
|
||||||
|
assert model.peripheralsChanged.emit.call_count == 3
|
||||||
|
assert model.peripherals == "test2"
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue