3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-11 00:37:50 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Prevent division by 0 if total download size is 0

Browse source 
This can happen if the downloads are all so small that it gets rounded to 0kB.

Fixes Sentry issue CURA-ZM.
This commit is contained in:
Ghostkeeper 2020-07-06 17:23:58 +02:00
parent f0456526b3
commit 3032221b70
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
3 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cura/PrinterOutput/Models/ExtruderOutputModel.py
View file

@ -99,7 +99,7 @@ class ExtruderOutputModel(QObject):
self._is_preheating = pre_heating self._is_preheating = pre_heating
self.isPreheatingChanged.emit() self.isPreheatingChanged.emit()
@pyqtProperty(bool, notify=isPreheatingChanged) @pyqtProperty(bool, notify = isPreheatingChanged)
def isPreheating(self) -> bool: def isPreheating(self) -> bool:
return self._is_preheating return self._is_preheating

4
cura_app.py
View file

@ -39,7 +39,7 @@ except ImportError:
parser = argparse.ArgumentParser(prog = "cura", parser = argparse.ArgumentParser(prog = "cura",
add_help = False) add_help = False)
parser.add_argument("--debug", parser.add_argument("--debug",
action="store_true", action = "store_true",
default = False, default = False,
help = "Turn on the debug mode by setting this option." help = "Turn on the debug mode by setting this option."
) )
@ -49,7 +49,7 @@ known_args = vars(parser.parse_known_args()[0])
if with_sentry_sdk: if with_sentry_sdk:
sentry_env = "unknown" # Start off with a "IDK" sentry_env = "unknown" # Start off with a "IDK"
if hasattr(sys, "frozen"): if hasattr(sys, "frozen"):
sentry_env = "production" # A frozen build has the posibility to be a "real" distribution. sentry_env = "production" # A frozen build has the possibility to be a "real" distribution.
if ApplicationMetadata.CuraVersion == "master": if ApplicationMetadata.CuraVersion == "master":
sentry_env = "development" # Master is always a development version. sentry_env = "development" # Master is always a development version.

4
plugins/Toolbox/src/CloudSync/DownloadPresenter.py
View file

@ -120,6 +120,10 @@ class DownloadPresenter:
received += item["received"] received += item["received"]
total += item["total"] total += item["total"]
if total == 0: # Total download size is 0, or unknown, or there are no progress items at all.
self._progress_message.setProgress(100.0)
return
self._progress_message.setProgress(100.0 * (received / total)) # [0 .. 100] % self._progress_message.setProgress(100.0 * (received / total)) # [0 .. 100] %
def _onError(self, package_id: str) -> None: def _onError(self, package_id: str) -> None: