Fix adding printers due to unused 'parent' parameter

The 'parent' parameter was unused, so I removed it. But I didn't remove all things that called it, apparently. I just removed some. I didn't try the stackbuilder.

Contributes to issue CURA-5330.
This commit is contained in:
Ghostkeeper 2018-06-01 14:02:32 +02:00
parent a0263676e1
commit 2fbcc22123
No known key found for this signature in database
GPG key ID: 5252B696FB5E7C7A
4 changed files with 9 additions and 10 deletions

View file

@ -39,8 +39,8 @@ from . import Exceptions
# This also means that operations on the stack that modifies the container ordering is prohibited and # This also means that operations on the stack that modifies the container ordering is prohibited and
# will raise an exception. # will raise an exception.
class CuraContainerStack(ContainerStack): class CuraContainerStack(ContainerStack):
def __init__(self, container_id: str, *args, **kwargs): def __init__(self, container_id: str):
super().__init__(container_id, *args, **kwargs) super().__init__(container_id)
self._container_registry = ContainerRegistry.getInstance() self._container_registry = ContainerRegistry.getInstance()

View file

@ -99,8 +99,7 @@ class CuraStackBuilder:
position = position, position = position,
variant_container = extruder_variant_container, variant_container = extruder_variant_container,
material_container = material_container, material_container = material_container,
quality_container = application.empty_quality_container, quality_container = application.empty_quality_container
global_stack = new_global_stack,
) )
new_extruder.setNextStack(new_global_stack) new_extruder.setNextStack(new_global_stack)
new_global_stack.addExtruder(new_extruder) new_global_stack.addExtruder(new_extruder)
@ -139,11 +138,11 @@ class CuraStackBuilder:
@classmethod @classmethod
def createExtruderStack(cls, new_stack_id: str, extruder_definition: DefinitionContainerInterface, machine_definition_id: str, def createExtruderStack(cls, new_stack_id: str, extruder_definition: DefinitionContainerInterface, machine_definition_id: str,
position: int, position: int,
variant_container, material_container, quality_container, global_stack) -> ExtruderStack: variant_container, material_container, quality_container) -> ExtruderStack:
from cura.CuraApplication import CuraApplication from cura.CuraApplication import CuraApplication
application = CuraApplication.getInstance() application = CuraApplication.getInstance()
stack = ExtruderStack(new_stack_id, parent = global_stack) stack = ExtruderStack(new_stack_id)
stack.setName(extruder_definition.getName()) stack.setName(extruder_definition.getName())
stack.setDefinition(extruder_definition) stack.setDefinition(extruder_definition)

View file

@ -25,8 +25,8 @@ if TYPE_CHECKING:
# #
# #
class ExtruderStack(CuraContainerStack): class ExtruderStack(CuraContainerStack):
def __init__(self, container_id: str, *args, **kwargs): def __init__(self, container_id: str):
super().__init__(container_id, *args, **kwargs) super().__init__(container_id)
self.addMetaDataEntry("type", "extruder_train") # For backward compatibility self.addMetaDataEntry("type", "extruder_train") # For backward compatibility

View file

@ -23,8 +23,8 @@ from .CuraContainerStack import CuraContainerStack
## Represents the Global or Machine stack and its related containers. ## Represents the Global or Machine stack and its related containers.
# #
class GlobalStack(CuraContainerStack): class GlobalStack(CuraContainerStack):
def __init__(self, container_id: str, *args, **kwargs): def __init__(self, container_id: str):
super().__init__(container_id, *args, **kwargs) super().__init__(container_id)
self.addMetaDataEntry("type", "machine") # For backward compatibility self.addMetaDataEntry("type", "machine") # For backward compatibility