From 2dd7be12714c268a82ff319b081ea50f7eec743e Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Thu, 1 Mar 2018 10:59:39 +0100 Subject: [PATCH] Add documentation for timers in Material and Quality managers --- cura/Machines/MaterialManager.py | 3 +++ cura/Machines/QualityManager.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/cura/Machines/MaterialManager.py b/cura/Machines/MaterialManager.py index 997d37a672..5b07811d34 100644 --- a/cura/Machines/MaterialManager.py +++ b/cura/Machines/MaterialManager.py @@ -39,6 +39,9 @@ class MaterialManager(QObject): self._default_machine_definition_id = "fdmprinter" self._default_approximate_diameter_for_quality_search = "3" + # When a material gets added/imported, there can be more than one InstanceContainers. In those cases, we don't + # want to react on every container/metadata changed signal. The timer here is to buffer it a bit so we don't + # react too many time. self._update_timer = QTimer(self) self._update_timer.setInterval(300) self._update_timer.setSingleShot(True) diff --git a/cura/Machines/QualityManager.py b/cura/Machines/QualityManager.py index 0bb2be1f89..5783f54064 100644 --- a/cura/Machines/QualityManager.py +++ b/cura/Machines/QualityManager.py @@ -169,6 +169,9 @@ class QualityManager(QObject): self._container_registry.containerAdded.connect(self._onContainerMetadataChanged) self._container_registry.containerRemoved.connect(self._onContainerMetadataChanged) + # When a custom quality gets added/imported, there can be more than one InstanceContainers. In those cases, + # we don't want to react on every container/metadata changed signal. The timer here is to buffer it a bit so + # we don't react too many time. self._update_timer = QTimer(self) self._update_timer.setInterval(300) self._update_timer.setSingleShot(True)