3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-08 07:27:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Handle non-happy path for downloading

Browse source 
CURA-6006
This commit is contained in:
Jaime van Kessel 2018-12-06 17:23:02 +01:00
parent 717fb260c1
commit 2c9c9d8c96
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugins/Toolbox/src/Toolbox.py
View file

@ -671,6 +671,11 @@ class Toolbox(QObject, Extension):
if bytes_sent == bytes_total:
self.setIsDownloading(False)
cast(QNetworkReply, self._download_reply).downloadProgress.disconnect(self._onDownloadProgress)
# Check if the download was sucessfull
if self._download_reply.attribute(QNetworkRequest.HttpStatusCodeAttribute) != 200:
Logger.log("w", "Failed to download package. The following error was returned: %s", json.loads(bytes(self._download_reply.readAll()).decode("utf-8")))
return
# Must not delete the temporary file on Windows
self._temp_plugin_file = tempfile.NamedTemporaryFile(mode = "w+b", suffix = ".curapackage", delete = False)
file_path = self._temp_plugin_file.name