From 2c7bd7883a4b725ac6ae2429e55ef27c6e486da7 Mon Sep 17 00:00:00 2001
From: "c.lamboo" <casperlamboo@gmail.com>
Date: Tue, 13 Dec 2022 17:05:51 +0100
Subject: [PATCH] Make recommended mode-window scrollable

CURA-9793
---
 .../PrintSetupSelectorContents.qml            |  4 +++
 .../Recommended/RecommendedPrintSetup.qml     | 27 ++++++++++++-------
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/resources/qml/PrintSetupSelector/PrintSetupSelectorContents.qml b/resources/qml/PrintSetupSelector/PrintSetupSelectorContents.qml
index 9d3da51356..52a22c6c76 100644
--- a/resources/qml/PrintSetupSelector/PrintSetupSelectorContents.qml
+++ b/resources/qml/PrintSetupSelector/PrintSetupSelectorContents.qml
@@ -67,6 +67,10 @@ Item
                 top: parent.top
             }
             visible: currentModeIndex == PrintSetupSelectorContents.Mode.Recommended
+            height: {
+                const height = base.height - (customPrintSetup.mapToItem(null, 0, 0).y + buttonRow.height + UM.Theme.getSize("default_margin").height);
+                return Math.min(implicitHeight, height);
+            }
 
             function onModeChanged()
             {
diff --git a/resources/qml/PrintSetupSelector/Recommended/RecommendedPrintSetup.qml b/resources/qml/PrintSetupSelector/Recommended/RecommendedPrintSetup.qml
index f78ae38dce..80e171bed4 100644
--- a/resources/qml/PrintSetupSelector/Recommended/RecommendedPrintSetup.qml
+++ b/resources/qml/PrintSetupSelector/Recommended/RecommendedPrintSetup.qml
@@ -2,34 +2,41 @@
 //Cura is released under the terms of the LGPLv3 or higher.
 
 import QtQuick 2.10
+import QtQuick.Controls 2.15
 import QtQuick.Layouts 1.1
 
 import UM 1.6 as UM
 import Cura 1.6 as Cura
 import ".."
 
-Item
+ScrollView
 {
     id: recommendedPrintSetup
 
-    height: childrenRect.height + 2 * padding
+    implicitHeight: settingsColumn.height + 2 * padding
 
     property bool settingsEnabled: Cura.ExtruderManager.activeExtruderStackId || extrudersEnabledCount.properties.value == 1
-    property real padding: UM.Theme.getSize("default_margin").width
+
+    padding: UM.Theme.getSize("default_margin").width
 
     function onModeChanged() {}
 
-    Column
-    {
-        spacing: UM.Theme.getSize("default_margin").height
-
+    ScrollBar.vertical: UM.ScrollBar {
+        id: scroll
         anchors
         {
-            left: parent.left
-            right: parent.right
             top: parent.top
-            margins: parent.padding
+            right: parent.right
+            bottom: parent.bottom
         }
+    }
+
+    Column
+    {
+        id: settingsColumn
+        spacing: UM.Theme.getSize("default_margin").height
+
+        width: recommendedPrintSetup.width - 2 * recommendedPrintSetup.padding - (scroll.visible ? scroll.width : 0)
 
         // TODO
         property real firstColumnWidth: Math.round(width / 3)