3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-16 11:17:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix error log spam.

Browse source 
The code is clearly written to take into account that 'addresses' may be null. But not that the whole 'addresses' attribute may not exist. And then instead of printing one warning (Could not get information about XX) it instead printed a stacktrace and retried and printed a stacktrace and retried and printed a stacktrace and.... It ended up driving me a bit nuts when looking at the logs for unrelated reasons. So Ifinallay fixed it. Could end up as a speedup in some cases as well I suppose?
This commit is contained in:
Remco Burema 2021-02-26 21:56:33 +01:00
parent fa4d1ba1fb
commit 2b88a2dc87
No known key found for this signature in database
GPG key ID: 215C49431D43F98C
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/UM3NetworkPrinting/src/Network/ZeroConfClient.py
View file

@ -129,16 +129,16 @@ class ZeroConfClient:
for record in zero_conf.cache.entries_with_name(info.server): for record in zero_conf.cache.entries_with_name(info.server):
info.update_record(zero_conf, time(), record) info.update_record(zero_conf, time(), record)
if info.addresses: if hasattr(info, "addresses") and info.addresses:
break break
# Request more data if info is not complete # Request more data if info is not complete
if not info.addresses: if not hasattr(info, "addresses") or not info.addresses:
new_info = zero_conf.get_service_info(service_type, name) new_info = zero_conf.get_service_info(service_type, name)
if new_info is not None: if new_info is not None:
info = new_info info = new_info
if info and info.addresses: if info and hasattr(info, "addresses") and info.addresses:
type_of_device = info.properties.get(b"type", None) type_of_device = info.properties.get(b"type", None)
if type_of_device: if type_of_device:
if type_of_device == b"printer": if type_of_device == b"printer":