From 29b90d26b82c97ba6998ca397d684c7b99723581 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 15 Jun 2017 16:16:43 +0200 Subject: [PATCH] Re-enable centre camera on selection With Qt 5.8 it works again on Windows. --- cura/CuraApplication.py | 5 ++--- resources/qml/Preferences/GeneralPage.qml | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cura/CuraApplication.py b/cura/CuraApplication.py index 5086d81de5..7995c77fce 100755 --- a/cura/CuraApplication.py +++ b/cura/CuraApplication.py @@ -268,7 +268,7 @@ class CuraApplication(QtApplication): Preferences.getInstance().addPreference("cura/categories_expanded", "") Preferences.getInstance().addPreference("cura/jobname_prefix", True) - Preferences.getInstance().addPreference("view/center_on_select", False) + Preferences.getInstance().addPreference("view/center_on_select", True) Preferences.getInstance().addPreference("mesh/scale_to_fit", False) Preferences.getInstance().addPreference("mesh/scale_tiny_meshes", True) Preferences.getInstance().addPreference("cura/dialog_on_project_save", True) @@ -751,8 +751,7 @@ class CuraApplication(QtApplication): # Default self.getController().setActiveTool("TranslateTool") - # Hack: QVector bindings are broken on PyQt 5.7.1 on Windows. This disables it being called at all. - if Preferences.getInstance().getValue("view/center_on_select") and not Platform.isWindows(): + if Preferences.getInstance().getValue("view/center_on_select"): self._center_after_select = True else: if self.getController().getActiveTool(): diff --git a/resources/qml/Preferences/GeneralPage.qml b/resources/qml/Preferences/GeneralPage.qml index 8930dbd02f..9248752f70 100755 --- a/resources/qml/Preferences/GeneralPage.qml +++ b/resources/qml/Preferences/GeneralPage.qml @@ -332,7 +332,6 @@ UM.PreferencesPage text: catalog.i18nc("@action:button","Center camera when item is selected"); checked: boolCheck(UM.Preferences.getValue("view/center_on_select")) onClicked: UM.Preferences.setValue("view/center_on_select", checked) - enabled: Qt.platform.os != "windows" // Hack: disable the feature on windows as it's broken for pyqt 5.7.1. } }