Fix typing

CURA-8588
This commit is contained in:
Jaime van Kessel 2022-01-03 11:44:05 +01:00
parent 7deeb26e13
commit 27e5905a32
3 changed files with 10 additions and 6 deletions

View file

@ -53,7 +53,6 @@ class PackageList(ListModel):
def __del__(self) -> None:
""" When this object is deleted it will loop through all registered API requests and aborts them """
try:
self.isLoadingChanged.disconnect()
self.hasMoreChanged.disconnect()
@ -192,7 +191,10 @@ class PackageList(ListModel):
Logger.warning(f"Could not install {package_id}")
return
package = self.getPackageModel(package_id)
self.subscribeUserToPackage(package_id, str(package.sdk_version))
if package:
self.subscribeUserToPackage(package_id, str(package.sdk_version))
else:
Logger.log("w", f"Unable to get data on package {package_id}")
def download(self, package_id: str, url: str, update: bool = False) -> None:
"""Initiate the download request
@ -283,7 +285,8 @@ class PackageList(ListModel):
self.download(package_id, url, False)
else:
package = self.getPackageModel(package_id)
self.subscribeUserToPackage(package_id, str(package.sdk_version))
if package:
self.subscribeUserToPackage(package_id, str(package.sdk_version))
def uninstallPackage(self, package_id: str) -> None:
"""Uninstall a package from the Marketplace