From 2749de9a6748a93ff1cda37c731660a630ec37a5 Mon Sep 17 00:00:00 2001 From: David Fries Date: Fri, 30 Aug 2024 09:12:03 -0500 Subject: [PATCH] Fix RecentFilesMenu.qml onObjectRemoved incompatible arguments "share/cura/resources/qml/Menus/RecentFilesMenu.qml:39: TypeError: Passing incompatible arguments to C++ functions from JavaScript is not allowed." This was passing the Instantiator index, which is a Number to menu.removeItem which is expecting an object. Add the missing index argument. I found Qt 5.7 had two arguments so it has been there for some time. --- resources/qml/ActionPanel/OutputProcessWidget.qml | 2 +- resources/qml/Menus/RecentFilesMenu.qml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/qml/ActionPanel/OutputProcessWidget.qml b/resources/qml/ActionPanel/OutputProcessWidget.qml index 1303dc20a2..c609cd6ca5 100644 --- a/resources/qml/ActionPanel/OutputProcessWidget.qml +++ b/resources/qml/ActionPanel/OutputProcessWidget.qml @@ -10,7 +10,7 @@ import Cura 1.0 as Cura // This element contains all the elements the user needs to visualize the data -// that is gather after the slicing process, such as printint time, material usage, ... +// that is gather after the slicing process, such as printing time, material usage, ... // There are also two buttons: one to previsualize the output layers, and the other to // select what to do with it (such as print over network, save to file, ...) Column diff --git a/resources/qml/Menus/RecentFilesMenu.qml b/resources/qml/Menus/RecentFilesMenu.qml index 19ff681219..93fddd0bf6 100644 --- a/resources/qml/Menus/RecentFilesMenu.qml +++ b/resources/qml/Menus/RecentFilesMenu.qml @@ -2,7 +2,7 @@ // Cura is released under the terms of the LGPLv3 or higher. import QtQuick 2.2 -import QtQuick.Controls 2.1 +import QtQuick.Controls 2.15 import UM 1.3 as UM import Cura 1.0 as Cura @@ -30,6 +30,6 @@ Cura.Menu onTriggered: CuraApplication.readLocalFile(modelData) } onObjectAdded: (index, object) => menu.insertItem(index, object) - onObjectRemoved: (object) => menu.removeItem(object) + onObjectRemoved: (index, object) => menu.removeItem(object) } }