From 7a9dbe3a3f2b29628a12db3952aa3c8a6ce90a0b Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Thu, 14 Feb 2019 14:24:34 +0100 Subject: [PATCH 1/2] Don't explode the log with errors when there's no cloud response --- plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py b/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py index adff94bbbc..bdb7f38d32 100644 --- a/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py +++ b/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py @@ -159,6 +159,9 @@ class CloudApiClient: model: Type[CloudApiClientModel], ) -> None: def parse() -> None: + # Don't try to parse the reply if we didn't get one + if reply.attribute(QNetworkRequest.HttpStatusCodeAttribute) is None: + return status_code, response = self._parseReply(reply) self._anti_gc_callbacks.remove(parse) return self._parseModels(response, on_finished, model) From ee0eb6aac2120dd9ed1a229cc6aef7848dc8987d Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Tue, 19 Feb 2019 10:20:28 +0100 Subject: [PATCH 2/2] Don't return value of self._parseModels Because it always returns none --- plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py b/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py index bdb7f38d32..87c7a50838 100644 --- a/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py +++ b/plugins/UM3NetworkPrinting/src/Cloud/CloudApiClient.py @@ -164,7 +164,8 @@ class CloudApiClient: return status_code, response = self._parseReply(reply) self._anti_gc_callbacks.remove(parse) - return self._parseModels(response, on_finished, model) + self._parseModels(response, on_finished, model) + return self._anti_gc_callbacks.append(parse) reply.finished.connect(parse)