3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-11-02 20:52:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
This commit is contained in:
Joey de l'Arago 2022-12-12 11:44:21 +01:00 • committed by GitHub
parent e03b4e07f9
commit 1e6184448c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

7
resources/qml/PrintSetupSelector/Recommended/RecommendedAdhesionSelector.qml
View file

@ -14,8 +14,8 @@ RecommendedSettingSection
title: catalog.i18nc("@label", "Adhesion")
icon: UM.Theme.getIcon("Adhesion")
enableSectionSwitchVisible: platformAdhesionType.properties.enabled == "True"
enableSectionSwitchChecked: platformAdhesionType.properties.value != "skirt" && platformAdhesionType.properties.value != "none"
enableSectionSwitchVisible: platformAdhesionType.properties.enabled === "True"
enableSectionSwitchChecked: platformAdhesionType.properties.value !== "skirt" && platformAdhesionType.properties.value !== "none"
enableSectionSwitchEnabled: recommendedPrintSetup.settingsEnabled
tooltipText: catalog.i18nc("@label", "Enable printing a brim or raft. This will add a flat area around or under your object which is easy to cut off afterwards.")
@ -30,7 +30,8 @@ RecommendedSettingSection
storeIndex: 0
}
function onEnableSectionChanged(state) {
function onEnableSectionChanged(state)
{
curaRecommendedMode.setAdhesion(state)
}
}

6
resources/qml/PrintSetupSelector/Recommended/RecommendedPrintSetup.qml
View file

@ -77,7 +77,8 @@ Item
Item { height: UM.Theme.getSize("narrow_margin").height } //Spacer
Column {
Column
{
id: settingColumn
width: parent.width
spacing: UM.Theme.getSize("thin_margin").height
@ -117,7 +118,8 @@ Item
width: parent.width
}
RecommendedAdhesionSelector {
RecommendedAdhesionSelector
{
width: parent.width
}
}

2
resources/qml/PrintSetupSelector/Recommended/RecommendedSettingItem.qml
View file

@ -41,7 +41,6 @@ Item
onExited: base.hideTooltip()
}
Loader
{
id: settingContainer
@ -86,7 +85,6 @@ Item
NumberAnimation { property: "Layout.minimumHeight"; duration: 100; }
// Animate section dissapearring as it closes
NumberAnimation { property: "opacity"; duration: 100; }
}
}
}

4
resources/qml/PrintSetupSelector/Recommended/RecommendedStrengthSelector.qml
View file

@ -1,4 +1,4 @@
// Copyright (c) 2022 Ultimaker
// Copyright (c) 2022 UltiMaker
// Cura is released under the terms of the LGPLv3 or higher.
import QtQuick 2.7
@ -40,7 +40,7 @@ RecommendedSettingSection
settingName: "infill_sparse_density"
updateAllExtruders: true
// disable slider when gradual support is enabled
enabled: parseInt(infillSteps.properties.value) == 0
enabled: parseInt(infillSteps.properties.value) === 0
function updateSetting(value)
{

1
resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml
View file

@ -59,7 +59,6 @@ RecommendedSettingSection
settingControl: Cura.SingleSettingExtruderSelectorBar
{
extruderSettingName: "support_extruder_nr"
}
},