3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-08-06 13:34:01 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Apply suggestions from code review

Browse source 
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
This commit is contained in:
Joey de l'Arago 2022-12-12 11:44:21 +01:00 • committed by GitHub
parent e03b4e07f9
commit 1e6184448c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 26 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

8
resources/qml/MachineSettings/ComboBoxWithOptions.qml
View file

@ -74,7 +74,7 @@ UM.TooltipArea
return
}
if (typeof propertyProvider.properties["options"] == "string")
if (typeof propertyProvider.properties["options"] === "string")
{
return
}
@ -84,9 +84,9 @@ UM.TooltipArea
{
var key = propertyProvider.properties["options"].keys()[i]
var value = propertyProvider.properties["options"][key]
append({ text: value, code: key})
append({ text: value, code: key })
if (propertyProvider.properties.value == key)
if (propertyProvider.properties.value === key)
{
comboBox.currentIndex = i
}
@ -132,7 +132,7 @@ UM.TooltipArea
onActivated:
{
var newValue = model.get(index).value
if (propertyProvider.properties.value != newValue && newValue != undefined)
if (propertyProvider.properties.value !== newValue && newValue !== undefined)
{
if (setValueFunction !== null)
{