3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-22 06:03:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

More early out if no global stack

Browse source 
This prevents all sorts of crashes on start-up, instead causing no active printer to appear and the add printer wizard to show up.

Contributes to issue CURA-5045.
This commit is contained in:
Ghostkeeper 2018-03-27 09:43:37 +02:00
parent f2c8d8756e
commit 1aea5356b6
No known key found for this signature in database
GPG key ID: 5252B696FB5E7C7A
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
cura/Settings/MachineManager.py
View file

@ -1014,6 +1014,8 @@ class MachineManager(QObject):
self.activeQualityChangesGroupChanged.emit() self.activeQualityChangesGroupChanged.emit()
def _setQualityChangesGroup(self, quality_changes_group): def _setQualityChangesGroup(self, quality_changes_group):
if self._global_container_stack is None:
return #Can't change that.
quality_type = quality_changes_group.quality_type quality_type = quality_changes_group.quality_type
quality_group_dict = self._quality_manager.getQualityGroups(self._global_container_stack) quality_group_dict = self._quality_manager.getQualityGroups(self._global_container_stack)
quality_group = quality_group_dict[quality_type] quality_group = quality_group_dict[quality_type]
@ -1082,6 +1084,8 @@ class MachineManager(QObject):
## Update current quality type and machine after setting material ## Update current quality type and machine after setting material
def _updateQualityWithMaterial(self, *args): def _updateQualityWithMaterial(self, *args):
if self._global_container_stack is None:
return
Logger.log("i", "Updating quality/quality_changes due to material change") Logger.log("i", "Updating quality/quality_changes due to material change")
current_quality_type = None current_quality_type = None
if self._current_quality_group: if self._current_quality_group:
@ -1280,6 +1284,8 @@ class MachineManager(QObject):
@pyqtSlot(str) @pyqtSlot(str)
def setQualityGroupByQualityType(self, quality_type): def setQualityGroupByQualityType(self, quality_type):
if self._global_container_stack is None:
return
# Get all the quality groups for this global stack and filter out by quality_type # Get all the quality groups for this global stack and filter out by quality_type
quality_group_dict = self._quality_manager.getQualityGroups(self._global_container_stack) quality_group_dict = self._quality_manager.getQualityGroups(self._global_container_stack)
quality_group = quality_group_dict[quality_type] quality_group = quality_group_dict[quality_type]