mirror of
https://github.com/Ultimaker/Cura.git
synced 2025-07-08 23:46:22 -06:00
Fix version comparison in plugin browser
CURA-5202 It was comparing with itself so there's never a version upgrade.
This commit is contained in:
parent
79a66b43ab
commit
19937d1be0
1 changed files with 7 additions and 8 deletions
|
@ -301,19 +301,18 @@ class PluginBrowser(QObject, Extension):
|
||||||
|
|
||||||
return self._plugins_model
|
return self._plugins_model
|
||||||
|
|
||||||
|
def _checkCanUpgrade(self, plugin_id, version):
|
||||||
|
if plugin_id not in self._plugin_registry.getInstalledPlugins():
|
||||||
|
return False
|
||||||
|
|
||||||
|
plugin_object = self._plugin_registry.getPluginObject(plugin_id)
|
||||||
def _checkCanUpgrade(self, id, version):
|
|
||||||
|
|
||||||
# TODO: This could maybe be done more efficiently using a dictionary...
|
|
||||||
|
|
||||||
# Scan plugin server data for plugin with the given id:
|
# Scan plugin server data for plugin with the given id:
|
||||||
for plugin in self._plugins_metadata:
|
for plugin in self._plugins_metadata:
|
||||||
if id == plugin["id"]:
|
if plugin_id == plugin["id"]:
|
||||||
reg_version = Version(version)
|
reg_version = Version(plugin_object.getVersion())
|
||||||
new_version = Version(plugin["version"])
|
new_version = Version(plugin["version"])
|
||||||
if new_version > reg_version:
|
if new_version > reg_version:
|
||||||
Logger.log("i", "%s has an update availible: %s", plugin["id"], plugin["version"])
|
Logger.log("i", "%s has an update available: %s", plugin["id"], plugin["version"])
|
||||||
return True
|
return True
|
||||||
return False
|
return False
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue