mirror of
https://github.com/Ultimaker/Cura.git
synced 2025-07-11 00:37:50 -06:00
Removed unnecessary checks
CURA-7090
This commit is contained in:
parent
e8f22beb27
commit
15a3922436
1 changed files with 2 additions and 6 deletions
|
@ -24,16 +24,13 @@ class SubscribedPackagesModel(ListModel):
|
||||||
self.addRoleName(Qt.UserRole + 5, "is_dismissed")
|
self.addRoleName(Qt.UserRole + 5, "is_dismissed")
|
||||||
|
|
||||||
def setMetadata(self, data: List[Dict[str, List[Any]]]) -> None:
|
def setMetadata(self, data: List[Dict[str, List[Any]]]) -> None:
|
||||||
if self._metadata != data:
|
self._metadata = data
|
||||||
self._metadata = data
|
|
||||||
|
|
||||||
def addDiscrepancies(self, discrepancy: List[str]) -> None:
|
def addDiscrepancies(self, discrepancy: List[str]) -> None:
|
||||||
if set(self._discrepancies) != set(discrepancy): # convert to set() to check if they are same list, regardless of list order
|
self._discrepancies = discrepancy
|
||||||
self._discrepancies = discrepancy
|
|
||||||
|
|
||||||
def initialize(self) -> None:
|
def initialize(self) -> None:
|
||||||
self._items.clear()
|
self._items.clear()
|
||||||
|
|
||||||
for item in self._metadata:
|
for item in self._metadata:
|
||||||
if item["package_id"] not in self._discrepancies:
|
if item["package_id"] not in self._discrepancies:
|
||||||
continue
|
continue
|
||||||
|
@ -49,7 +46,6 @@ class SubscribedPackagesModel(ListModel):
|
||||||
package.update({"icon_url": item["icon_url"]})
|
package.update({"icon_url": item["icon_url"]})
|
||||||
except KeyError: # There is no 'icon_url" in the response payload for this package
|
except KeyError: # There is no 'icon_url" in the response payload for this package
|
||||||
package.update({"icon_url": ""})
|
package.update({"icon_url": ""})
|
||||||
|
|
||||||
self._items.append(package)
|
self._items.append(package)
|
||||||
self.setItems(self._items)
|
self.setItems(self._items)
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue