3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-11 00:37:50 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Removed unnecessary checks

Browse source 
CURA-7090
This commit is contained in:
Dimitriovski 2020-01-14 14:07:55 +01:00
parent e8f22beb27
commit 15a3922436
No known key found for this signature in database
GPG key ID: 4E62757E2B0D304D
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/Toolbox/src/SubscribedPackagesModel.py
View file

@ -24,16 +24,13 @@ class SubscribedPackagesModel(ListModel):
self.addRoleName(Qt.UserRole + 5, "is_dismissed") self.addRoleName(Qt.UserRole + 5, "is_dismissed")
def setMetadata(self, data: List[Dict[str, List[Any]]]) -> None: def setMetadata(self, data: List[Dict[str, List[Any]]]) -> None:
if self._metadata != data: self._metadata = data
self._metadata = data
def addDiscrepancies(self, discrepancy: List[str]) -> None: def addDiscrepancies(self, discrepancy: List[str]) -> None:
if set(self._discrepancies) != set(discrepancy): # convert to set() to check if they are same list, regardless of list order self._discrepancies = discrepancy
self._discrepancies = discrepancy
def initialize(self) -> None: def initialize(self) -> None:
self._items.clear() self._items.clear()
for item in self._metadata: for item in self._metadata:
if item["package_id"] not in self._discrepancies: if item["package_id"] not in self._discrepancies:
continue continue
@ -49,7 +46,6 @@ class SubscribedPackagesModel(ListModel):
package.update({"icon_url": item["icon_url"]}) package.update({"icon_url": item["icon_url"]})
except KeyError: # There is no 'icon_url" in the response payload for this package except KeyError: # There is no 'icon_url" in the response payload for this package
package.update({"icon_url": ""}) package.update({"icon_url": ""})
self._items.append(package) self._items.append(package)
self.setItems(self._items) self.setItems(self._items)