From 1457569aeb8226157e5f0a1bee40b4780e29a432 Mon Sep 17 00:00:00 2001 From: Saumya Jain Date: Wed, 10 Apr 2024 17:24:55 +0200 Subject: [PATCH] Fix handling of undefined printer items in AddLocalPrinterScrollView This commit addresses an issue wherein undefined current items were not properly handled in the AddLocalPrinterScrollView module. We've changed the code so that it now checks if currentItem and currentItem.name exist before attempting to assign. If they don't exist, we now set default values to avoid null or undefined references. This prevents potential errors or inconsistent behaviors in the UI. CURA-11003 --- .../qml/WelcomePages/AddLocalPrinterScrollView.qml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/resources/qml/WelcomePages/AddLocalPrinterScrollView.qml b/resources/qml/WelcomePages/AddLocalPrinterScrollView.qml index 0376bfcfcc..1b00aad94a 100644 --- a/resources/qml/WelcomePages/AddLocalPrinterScrollView.qml +++ b/resources/qml/WelcomePages/AddLocalPrinterScrollView.qml @@ -32,7 +32,7 @@ Item onCurrentItemChanged: { - printerName = currentItem == null ? "" : currentItem.name + printerName = currentItem && currentItem.name? currentItem.name: "" } function updateCurrentItemUponSectionChange(section) @@ -53,12 +53,18 @@ Item { machineList.currentIndex = index; currentItem = machineList.model.getItem(index); - if (currentItem != undefined) + if (currentItem && currentItem.name) { machineName.text = currentItem.name manufacturer.text = currentItem.metadata["manufacturer"] author.text = currentItem.metadata["author"] } + else + { + machineName.text = "No printers Found" + manufacturer.text = "" + author.text = "" + } } Component.onCompleted: @@ -93,7 +99,6 @@ Item id: background color: UM.Theme.getColor("main_background") radius: 2 - border.width: 1 border.color: UM.Theme.getColor("primary_button") } height: UM.Theme.getSize("small_button_icon").height*2