From 2aba5ca840f43faf0b9f126ad799cda2ec32fc15 Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 14:22:15 +0100 Subject: [PATCH 1/2] IDK --- .github/workflows/cura-all-installers.yml | 4 ---- .github/workflows/cura-installer.yml | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cura-all-installers.yml b/.github/workflows/cura-all-installers.yml index cf737f810b..03ad65f7d4 100644 --- a/.github/workflows/cura-all-installers.yml +++ b/.github/workflows/cura-all-installers.yml @@ -72,7 +72,6 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false secrets: inherit windows-installer-create-msi: @@ -102,7 +101,6 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false secrets: inherit linux-modern-installer-create: @@ -117,7 +115,6 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false secrets: inherit macos-installer-create: @@ -132,5 +129,4 @@ jobs: enterprise: ${{ inputs.enterprise }} staging: ${{ inputs.staging }} installer: ${{ inputs.installer }} - msi: false secrets: inherit diff --git a/.github/workflows/cura-installer.yml b/.github/workflows/cura-installer.yml index 69dc0dedb3..c42d781da6 100644 --- a/.github/workflows/cura-installer.yml +++ b/.github/workflows/cura-installer.yml @@ -46,9 +46,9 @@ on: type: boolean msi: description: 'Create the msi' - default: 'false' + default: false required: true - type: string + type: boolean env: CONAN_LOGIN_USERNAME_CURA: ${{ secrets.CONAN_USER }} From 44126324d5f1df3615045b4c518045be0ff87421 Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 14:23:57 +0100 Subject: [PATCH 2/2] IDK --- .github/workflows/cura-installer.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cura-installer.yml b/.github/workflows/cura-installer.yml index c42d781da6..940bfe7e35 100644 --- a/.github/workflows/cura-installer.yml +++ b/.github/workflows/cura-installer.yml @@ -47,7 +47,7 @@ on: msi: description: 'Create the msi' default: false - required: true + required: false type: boolean env: