3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-18 20:28:01 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Implemented code review suggestions

Browse source 
Contributes to CURA-8558
This commit is contained in:
Jelle Spijker 2021-11-04 08:19:05 +01:00 • committed by Jelle Spijker
parent e01e47b8fa
commit 11b3b08198
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
3 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugins/Marketplace/PackageList.py
View file

@ -2,7 +2,7 @@
# Cura is released under the terms of the LGPLv3 or higher.
from PyQt5.QtCore import pyqtProperty, pyqtSignal, pyqtSlot, Qt
from typing import TYPE_CHECKING
from typing import Optional, TYPE_CHECKING
from UM.i18n import i18nCatalog
from UM.Qt.ListModel import ListModel
@ -19,7 +19,7 @@ class PackageList(ListModel):
"""
PackageRole = Qt.UserRole + 1
def __init__(self, parent: "QObject" = None) -> None:
def __init__(self, parent: Optional["QObject"] = None) -> None:
super().__init__(parent)
self._error_message = ""
self.addRoleName(self.PackageRole, "package")
@ -56,7 +56,7 @@ class PackageList(ListModel):
"""
return self._is_loading
hasMoreChanged = pyqtSignal() # The signal for hasMore property
hasMoreChanged = pyqtSignal()
def setHasMore(self, value: bool) -> None:
if self._has_more != value:
@ -70,7 +70,7 @@ class PackageList(ListModel):
"""
return self._has_more
errorMessageChanged = pyqtSignal() # The signal for errorMessage property
errorMessageChanged = pyqtSignal()
def setErrorMessage(self, error_message: str) -> None:
if self._error_message != error_message: