3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-18 04:07:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix some tests not cleaning up correctly after themselves

Browse source 
The PrintInformation test wasn't cleaning up after itself correclty. This
left some stuff behind that the other tests were using. Since this is bad (as at that point
tests can influence other tests), i've fixed that
This commit is contained in:
Jaime van Kessel 2019-12-24 16:20:09 +01:00
parent 04125d4608
commit 0862fd493e
No known key found for this signature in database
GPG key ID: 3710727397403C91
6 changed files with 37 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/Machines/Models/TestDiscoveredPrintersModel.py
View file

@ -14,6 +14,7 @@ def discovered_printer() -> DiscoveredPrinter:
return DiscoveredPrinter("127.0.0.1", "zomg", "yay", None, "bleep", MagicMock())
@pytest.mark.skip # TODO: This has some unknown dependency on the applicaiton / registry, which is hard to patch out. (which doesn't mean we shouldn't fix it!)
def test_discoveredPrinters(discovered_printer_model):
mocked_device = MagicMock()
cluster_size = PropertyMock(return_value = 1)
@ -36,6 +37,7 @@ def test_discoveredPrinters(discovered_printer_model):
discovered_printer_model.removeDiscoveredPrinter("ip")
assert discovered_printer_model.discoveredPrintersChanged.emit.call_count == 1
test_validate_data_get_set = [
{"attribute": "name", "value": "zomg"},
{"attribute": "machineType", "value": "BHDHAHHADAD"},