From a82e4bbb0b2ea63f39b4a3f2345d21e0e0e571c6 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 12 Jun 2019 13:31:30 +0200 Subject: [PATCH 1/2] Remove setting from 'values' category Oops. Contributes to issue CURA-6311. --- .../VersionUpgrade41to42/VersionUpgrade41to42.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py b/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py index 3e43a476f7..a9a2cbc2be 100644 --- a/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py +++ b/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py @@ -47,8 +47,8 @@ class VersionUpgrade41to42(VersionUpgrade): if "values" in parser: for old_name, new_name in _renamed_settings.items(): if old_name in parser["values"]: - parser[new_name] = parser[old_name] - del parser[old_name] + parser["values"][new_name] = parser["values"][old_name] + del parser["values"][old_name] result = io.StringIO() parser.write(result) From 2fb722b2874820b5978fbbf49eb236aaf0787fa9 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 12 Jun 2019 13:32:43 +0200 Subject: [PATCH 2/2] Apply changed visible settings to preferences file Otherwise the change will not be made to the actual file, just in memory. Contributes to issue CURA-6311. --- .../VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py b/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py index a9a2cbc2be..af01d4c1e0 100644 --- a/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py +++ b/plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py @@ -72,6 +72,7 @@ class VersionUpgrade41to42(VersionUpgrade): if old_name in visible_settings: visible_settings.remove(old_name) visible_settings.add(new_name) + parser["general"]["visible_settings"] = ";".join(visible_settings) result = io.StringIO() parser.write(result)