3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-07 15:07:28 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Implement pagination for package list

Browse source 
The simplest way I can think of.
Currently we only call the request function once, so we can only get the first page. Before calling it multiple times, we should check if there are more pages by checking if the request URL is an empty string.

Contributes to issue CURA-8556.
This commit is contained in:
Ghostkeeper 2021-10-21 16:56:53 +02:00
parent b585c02207
commit 031c8efbe6
No known key found for this signature in database
GPG key ID: D2A8871EE34EC59A
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
plugins/Marketplace/PackageList.py
View file

@ -33,12 +33,13 @@ class PackageList(ListModel):
self._is_loading = True
self._scope = JsonDecoratorScope(UltimakerCloudScope(CuraApplication.getInstance()))
self._request_url = f"{Marketplace.PACKAGES_URL}?limit={self.ITEMS_PER_PAGE}"
self.addRoleName(self.PackageRole, "package")
self.requestFirst()
self.request()
def requestFirst(self) -> None:
def request(self) -> None:
"""
Make a request for the first paginated page of packages.
@ -48,7 +49,7 @@ class PackageList(ListModel):
http = HttpRequestManager.getInstance()
http.get(
Marketplace.PACKAGES_URL,
self._request_url,
scope = self._scope,
callback = self._parseResponse,
error_callback = self._onError
@ -78,13 +79,15 @@ class PackageList(ListModel):
:param reply: A reply containing information about a number of packages.
"""
response_data = HttpRequestManager.readJSON(reply)
if "data" not in response_data:
if "data" not in response_data or "links" not in response_data:
return # TODO: Handle invalid response.
for package_data in response_data["data"]:
package = PackageModel(package_data, parent = self)
self.appendItem({"package": package}) # Add it to this list model.
self._request_url = response_data["links"].get("next", "") # Use empty string to signify that there is no next page.
def _onError(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]) -> None:
"""
Handles networking and server errors when requesting the list of packages.