From 02ba46b29f9ce5ec08099c584cf92474d1aa6c6a Mon Sep 17 00:00:00 2001
From: Lipu Fei <lipu.fei815@gmail.com>
Date: Tue, 1 Aug 2017 08:23:27 +0200
Subject: [PATCH] Add support_skip_zag_per_mm

CURA-3957
---
 resources/definitions/fdmprinter.def.json | 35 +++++++++++++++++------
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json
index 5528c59560..ed79728122 100755
--- a/resources/definitions/fdmprinter.def.json
+++ b/resources/definitions/fdmprinter.def.json
@@ -3405,7 +3405,7 @@
                 "support_skip_some_zags":
                 {
                     "label": "Skip Some Support Line Connections",
-                    "description": "Skip some support line connections to make the support structure easier to break away.",
+                    "description": "Skip some support line connections to make the support structure easier to break away. This setting is applicable to the Zig Zag support infill pattern.",
                     "type": "bool",
                     "default_value": false,
                     "enabled": "support_enable and (support_pattern == 'zigzag')",
@@ -3413,18 +3413,35 @@
                     "settable_per_mesh": false,
                     "settable_per_extruder": true
                 },
-                "support_zag_skip_count":
+                "support_skip_zag_per_mm":
                 {
-                    "label": "Support Line Connection Skip Chunk Size",
-                    "description": "Skip one in every N connection lines to make the support structure easier to break away.",
-                    "type": "int",
-                    "default_value": 6,
-                    "minimum_value": "1",
-                    "minimum_value_warning": "3",
+                    "label": "Support Line Skip Frequency",
+                    "description": "To skip one connection line in every N mm to make the support structure easier to break away.",
+                    "type": "float",
+                    "value": "support_line_distance * 5",
+                    "minimum_value": "0",
+                    "minimum_value_warning": "support_line_distance",
                     "enabled": "support_enable and (support_pattern == 'zigzag') and support_skip_some_zags",
                     "limit_to_extruder": "support_infill_extruder_nr",
                     "settable_per_mesh": false,
-                    "settable_per_extruder": true
+                    "settable_per_extruder": true,
+                    "children":
+                    {
+                        "support_zag_skip_count":
+                        {
+                            "label": "Support Chunk Size",
+                            "description": "Skip one in every N connection lines to make the support structure easier to break away.",
+                            "type": "int",
+                            "default_value": 5,
+                            "value": "round(support_skip_zag_per_mm / support_line_distance)",
+                            "minimum_value": "1",
+                            "minimum_value_warning": "3",
+                            "enabled": "support_enable and (support_pattern == 'zigzag') and support_skip_some_zags",
+                            "limit_to_extruder": "support_infill_extruder_nr",
+                            "settable_per_mesh": false,
+                            "settable_per_extruder": true
+                        }
+                    }
                 },
                 "support_infill_rate":
                 {