3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-06 22:47:29 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Storing multiple ongoing_requests

Browse source 
A bit of defensive programming

Contributes to: CURA-8587
This commit is contained in:
Jelle Spijker 2021-12-07 15:56:35 +01:00
parent dae92c354c
commit 013e0b51e9
No known key found for this signature in database
GPG key ID: 6662DC033BE6B99A
3 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
plugins/Marketplace/RemotePackageList.py
View file

@ -29,6 +29,7 @@ class RemotePackageList(PackageList):
self._requested_search_string = ""
self._current_search_string = ""
self._request_url = self._initialRequestUrl()
self._ongoing_requests["get_packages"] = None
self.isLoadingChanged.connect(self._onLoadingChanged)
self.isLoadingChanged.emit()
@ -49,7 +50,7 @@ class RemotePackageList(PackageList):
self.setErrorMessage("") # Clear any previous errors.
self.setIsLoading(True)
self._ongoing_request = HttpRequestManager.getInstance().get(
self._ongoing_requests["get_packages"] = HttpRequestManager.getInstance().get(
self._request_url,
scope = self._scope,
callback = self._parseResponse,
@ -58,8 +59,8 @@ class RemotePackageList(PackageList):
@pyqtSlot()
def abortUpdating(self) -> None:
HttpRequestManager.getInstance().abortRequest(self._ongoing_request)
self._ongoing_request = None
HttpRequestManager.getInstance().abortRequest(self._ongoing_requests["get_packages"])
self._ongoing_requests["get_packages"] = None
def reset(self) -> None:
self.clear()