3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-19 04:37:51 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Review feedback

Browse source 
Contributes to CL-1051
This commit is contained in:
Ian Paschal 2018-10-01 16:32:30 +02:00
parent 97fa5094ce
commit 00ce3b0083
2 changed files with 10 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
plugins/UM3NetworkPrinting/resources/qml/PrintJobInfoBlock.qml
View file

@ -48,15 +48,13 @@ Item {
height: childrenRect.height;
// Main content
Rectangle {
Item {
id: mainContent;
color: root.debug ? "red" : "transparent";
width: parent.width;
height: 200; // TODO: Theme!
// Left content
Rectangle {
color: root.debug ? "lightblue" : "transparent";
Item {
anchors {
left: parent.left;
right: parent.horizontalCenter;
@ -179,8 +177,7 @@ Item {
}
// Right content
Rectangle {
color: root.debug ? "blue" : "transparent";
Item {
anchors {
left: parent.horizontalCenter;
right: parent.right;
@ -238,7 +235,7 @@ Item {
}
}
Rectangle {
Item {
id: configChangesBox;
width: parent.width;
height: childrenRect.height;
@ -322,9 +319,8 @@ Item {
}
// Config change details
Rectangle {
Item {
id: configChangeDetails;
color: "transparent";
width: parent.width;
visible: false;
// In case of really massive multi-line configuration changes
@ -332,8 +328,7 @@ Item {
Behavior on height { NumberAnimation { duration: 100 } }
anchors.top: configChangeToggle.bottom;
Rectangle {
color: "transparent";
Item {
clip: true;
anchors {
fill: parent;

6
plugins/UM3NetworkPrinting/resources/qml/PrinterInfoBlock.qml
View file

@ -73,12 +73,10 @@ Item {
if (root.printJob) {
// Use more-specific print job if possible
return root.printJob.configuration.extruderConfigurations[i];
} else {
}
if (root.printer) {
return root.printer.printerConfiguration.extruderConfigurations[i];
} else {
}
return null;
}
}
}
}