3D-printing/Cura
1
0
Fork 0
mirror of https://github.com/Ultimaker/Cura.git synced 2025-07-19 12:47:49 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Review feedback

Browse source 
Contributes to CL-1051
This commit is contained in:
Ian Paschal 2018-10-01 16:32:30 +02:00
parent 97fa5094ce
commit 00ce3b0083
2 changed files with 10 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
plugins/UM3NetworkPrinting/resources/qml/PrintJobInfoBlock.qml
View file

@ -48,15 +48,13 @@ Item {
height: childrenRect.height; height: childrenRect.height;
// Main content // Main content
Rectangle { Item {
id: mainContent; id: mainContent;
color: root.debug ? "red" : "transparent";
width: parent.width; width: parent.width;
height: 200; // TODO: Theme! height: 200; // TODO: Theme!
// Left content // Left content
Rectangle { Item {
color: root.debug ? "lightblue" : "transparent";
anchors { anchors {
left: parent.left; left: parent.left;
right: parent.horizontalCenter; right: parent.horizontalCenter;
@ -179,8 +177,7 @@ Item {
} }
// Right content // Right content
Rectangle { Item {
color: root.debug ? "blue" : "transparent";
anchors { anchors {
left: parent.horizontalCenter; left: parent.horizontalCenter;
right: parent.right; right: parent.right;
@ -238,7 +235,7 @@ Item {
} }
} }
Rectangle { Item {
id: configChangesBox; id: configChangesBox;
width: parent.width; width: parent.width;
height: childrenRect.height; height: childrenRect.height;
@ -322,9 +319,8 @@ Item {
} }
// Config change details // Config change details
Rectangle { Item {
id: configChangeDetails; id: configChangeDetails;
color: "transparent";
width: parent.width; width: parent.width;
visible: false; visible: false;
// In case of really massive multi-line configuration changes // In case of really massive multi-line configuration changes
@ -332,8 +328,7 @@ Item {
Behavior on height { NumberAnimation { duration: 100 } } Behavior on height { NumberAnimation { duration: 100 } }
anchors.top: configChangeToggle.bottom; anchors.top: configChangeToggle.bottom;
Rectangle { Item {
color: "transparent";
clip: true; clip: true;
anchors { anchors {
fill: parent; fill: parent;

6
plugins/UM3NetworkPrinting/resources/qml/PrinterInfoBlock.qml
View file

@ -73,12 +73,10 @@ Item {
if (root.printJob) { if (root.printJob) {
// Use more-specific print job if possible // Use more-specific print job if possible
return root.printJob.configuration.extruderConfigurations[i]; return root.printJob.configuration.extruderConfigurations[i];
} else { }
if (root.printer) { if (root.printer) {
return root.printer.printerConfiguration.extruderConfigurations[i]; return root.printer.printerConfiguration.extruderConfigurations[i];
} else { }
return null; return null;
} }
}
}
} }